|
@@ -710,9 +710,7 @@ static irqreturn_t saa7164_irq(int irq, void *dev_id)
|
|
} else {
|
|
} else {
|
|
/* Find the function */
|
|
/* Find the function */
|
|
dprintk(DBGLVL_IRQ,
|
|
dprintk(DBGLVL_IRQ,
|
|
- "%s() unhandled interrupt "
|
|
|
|
- "reg 0x%x bit 0x%x "
|
|
|
|
- "intid = 0x%x\n",
|
|
|
|
|
|
+ "%s() unhandled interrupt reg 0x%x bit 0x%x intid = 0x%x\n",
|
|
__func__, i, bit, intid);
|
|
__func__, i, bit, intid);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
@@ -767,13 +765,11 @@ void saa7164_dumpregs(struct saa7164_dev *dev, u32 addr)
|
|
{
|
|
{
|
|
int i;
|
|
int i;
|
|
|
|
|
|
- dprintk(1, "--------------------> "
|
|
|
|
- "00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f\n");
|
|
|
|
|
|
+ dprintk(1, "--------------------> 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f\n");
|
|
|
|
|
|
for (i = 0; i < 0x100; i += 16)
|
|
for (i = 0; i < 0x100; i += 16)
|
|
- dprintk(1, "region0[0x%08x] = "
|
|
|
|
- "%02x %02x %02x %02x %02x %02x %02x %02x"
|
|
|
|
- " %02x %02x %02x %02x %02x %02x %02x %02x\n", i,
|
|
|
|
|
|
+ dprintk(1, "region0[0x%08x] = %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x\n",
|
|
|
|
+ i,
|
|
(u8)saa7164_readb(addr + i + 0),
|
|
(u8)saa7164_readb(addr + i + 0),
|
|
(u8)saa7164_readb(addr + i + 1),
|
|
(u8)saa7164_readb(addr + i + 1),
|
|
(u8)saa7164_readb(addr + i + 2),
|
|
(u8)saa7164_readb(addr + i + 2),
|
|
@@ -825,8 +821,7 @@ static void saa7164_dump_hwdesc(struct saa7164_dev *dev)
|
|
|
|
|
|
static void saa7164_dump_intfdesc(struct saa7164_dev *dev)
|
|
static void saa7164_dump_intfdesc(struct saa7164_dev *dev)
|
|
{
|
|
{
|
|
- dprintk(1, "@0x%p intfdesc "
|
|
|
|
- "sizeof(struct tmComResInterfaceDescr) = %d bytes\n",
|
|
|
|
|
|
+ dprintk(1, "@0x%p intfdesc sizeof(struct tmComResInterfaceDescr) = %d bytes\n",
|
|
&dev->intfdesc, (u32)sizeof(struct tmComResInterfaceDescr));
|
|
&dev->intfdesc, (u32)sizeof(struct tmComResInterfaceDescr));
|
|
|
|
|
|
dprintk(1, " .bLength = 0x%x\n", dev->intfdesc.bLength);
|
|
dprintk(1, " .bLength = 0x%x\n", dev->intfdesc.bLength);
|
|
@@ -1011,8 +1006,7 @@ static int saa7164_dev_setup(struct saa7164_dev *dev)
|
|
saa7164_port_init(dev, SAA7164_PORT_VBI2);
|
|
saa7164_port_init(dev, SAA7164_PORT_VBI2);
|
|
|
|
|
|
if (get_resources(dev) < 0) {
|
|
if (get_resources(dev) < 0) {
|
|
- printk(KERN_ERR "CORE %s No more PCIe resources for "
|
|
|
|
- "subsystem: %04x:%04x\n",
|
|
|
|
|
|
+ printk(KERN_ERR "CORE %s No more PCIe resources for subsystem: %04x:%04x\n",
|
|
dev->name, dev->pci->subsystem_vendor,
|
|
dev->name, dev->pci->subsystem_vendor,
|
|
dev->pci->subsystem_device);
|
|
dev->pci->subsystem_device);
|
|
|
|
|
|
@@ -1204,8 +1198,8 @@ static bool saa7164_enable_msi(struct pci_dev *pci_dev, struct saa7164_dev *dev)
|
|
err = pci_enable_msi(pci_dev);
|
|
err = pci_enable_msi(pci_dev);
|
|
|
|
|
|
if (err) {
|
|
if (err) {
|
|
- printk(KERN_ERR "%s() Failed to enable MSI interrupt."
|
|
|
|
- " Falling back to a shared IRQ\n", __func__);
|
|
|
|
|
|
+ printk(KERN_ERR "%s() Failed to enable MSI interrupt. Falling back to a shared IRQ\n",
|
|
|
|
+ __func__);
|
|
return false;
|
|
return false;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -1215,8 +1209,8 @@ static bool saa7164_enable_msi(struct pci_dev *pci_dev, struct saa7164_dev *dev)
|
|
|
|
|
|
if (err) {
|
|
if (err) {
|
|
/* fall back to legacy interrupt */
|
|
/* fall back to legacy interrupt */
|
|
- printk(KERN_ERR "%s() Failed to get an MSI interrupt."
|
|
|
|
- " Falling back to a shared IRQ\n", __func__);
|
|
|
|
|
|
+ printk(KERN_ERR "%s() Failed to get an MSI interrupt. Falling back to a shared IRQ\n",
|
|
|
|
+ __func__);
|
|
pci_disable_msi(pci_dev);
|
|
pci_disable_msi(pci_dev);
|
|
return false;
|
|
return false;
|
|
}
|
|
}
|
|
@@ -1256,8 +1250,8 @@ static int saa7164_initdev(struct pci_dev *pci_dev,
|
|
/* print pci info */
|
|
/* print pci info */
|
|
dev->pci_rev = pci_dev->revision;
|
|
dev->pci_rev = pci_dev->revision;
|
|
pci_read_config_byte(pci_dev, PCI_LATENCY_TIMER, &dev->pci_lat);
|
|
pci_read_config_byte(pci_dev, PCI_LATENCY_TIMER, &dev->pci_lat);
|
|
- printk(KERN_INFO "%s/0: found at %s, rev: %d, irq: %d, "
|
|
|
|
- "latency: %d, mmio: 0x%llx\n", dev->name,
|
|
|
|
|
|
+ printk(KERN_INFO "%s/0: found at %s, rev: %d, irq: %d, latency: %d, mmio: 0x%llx\n",
|
|
|
|
+ dev->name,
|
|
pci_name(pci_dev), dev->pci_rev, pci_dev->irq,
|
|
pci_name(pci_dev), dev->pci_rev, pci_dev->irq,
|
|
dev->pci_lat,
|
|
dev->pci_lat,
|
|
(unsigned long long)pci_resource_start(pci_dev, 0));
|
|
(unsigned long long)pci_resource_start(pci_dev, 0));
|
|
@@ -1307,8 +1301,7 @@ static int saa7164_initdev(struct pci_dev *pci_dev,
|
|
err = saa7164_downloadfirmware(dev);
|
|
err = saa7164_downloadfirmware(dev);
|
|
if (err < 0) {
|
|
if (err < 0) {
|
|
printk(KERN_ERR
|
|
printk(KERN_ERR
|
|
- "Failed to boot firmware, no features "
|
|
|
|
- "registered\n");
|
|
|
|
|
|
+ "Failed to boot firmware, no features registered\n");
|
|
goto fail_fw;
|
|
goto fail_fw;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -1327,8 +1320,7 @@ static int saa7164_initdev(struct pci_dev *pci_dev,
|
|
*/
|
|
*/
|
|
version = 0;
|
|
version = 0;
|
|
if (saa7164_api_get_fw_version(dev, &version) == SAA_OK)
|
|
if (saa7164_api_get_fw_version(dev, &version) == SAA_OK)
|
|
- dprintk(1, "Bus is operating correctly using "
|
|
|
|
- "version %d.%d.%d.%d (0x%x)\n",
|
|
|
|
|
|
+ dprintk(1, "Bus is operating correctly using version %d.%d.%d.%d (0x%x)\n",
|
|
(version & 0x0000fc00) >> 10,
|
|
(version & 0x0000fc00) >> 10,
|
|
(version & 0x000003e0) >> 5,
|
|
(version & 0x000003e0) >> 5,
|
|
(version & 0x0000001f),
|
|
(version & 0x0000001f),
|
|
@@ -1356,45 +1348,43 @@ static int saa7164_initdev(struct pci_dev *pci_dev,
|
|
/* Begin to create the video sub-systems and register funcs */
|
|
/* Begin to create the video sub-systems and register funcs */
|
|
if (saa7164_boards[dev->board].porta == SAA7164_MPEG_DVB) {
|
|
if (saa7164_boards[dev->board].porta == SAA7164_MPEG_DVB) {
|
|
if (saa7164_dvb_register(&dev->ports[SAA7164_PORT_TS1]) < 0) {
|
|
if (saa7164_dvb_register(&dev->ports[SAA7164_PORT_TS1]) < 0) {
|
|
- printk(KERN_ERR "%s() Failed to register "
|
|
|
|
- "dvb adapters on porta\n",
|
|
|
|
|
|
+ printk(KERN_ERR "%s() Failed to register dvb adapters on porta\n",
|
|
__func__);
|
|
__func__);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
if (saa7164_boards[dev->board].portb == SAA7164_MPEG_DVB) {
|
|
if (saa7164_boards[dev->board].portb == SAA7164_MPEG_DVB) {
|
|
if (saa7164_dvb_register(&dev->ports[SAA7164_PORT_TS2]) < 0) {
|
|
if (saa7164_dvb_register(&dev->ports[SAA7164_PORT_TS2]) < 0) {
|
|
- printk(KERN_ERR"%s() Failed to register "
|
|
|
|
- "dvb adapters on portb\n",
|
|
|
|
|
|
+ printk(KERN_ERR"%s() Failed to register dvb adapters on portb\n",
|
|
__func__);
|
|
__func__);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
if (saa7164_boards[dev->board].portc == SAA7164_MPEG_ENCODER) {
|
|
if (saa7164_boards[dev->board].portc == SAA7164_MPEG_ENCODER) {
|
|
if (saa7164_encoder_register(&dev->ports[SAA7164_PORT_ENC1]) < 0) {
|
|
if (saa7164_encoder_register(&dev->ports[SAA7164_PORT_ENC1]) < 0) {
|
|
- printk(KERN_ERR"%s() Failed to register "
|
|
|
|
- "mpeg encoder\n", __func__);
|
|
|
|
|
|
+ printk(KERN_ERR"%s() Failed to register mpeg encoder\n",
|
|
|
|
+ __func__);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
if (saa7164_boards[dev->board].portd == SAA7164_MPEG_ENCODER) {
|
|
if (saa7164_boards[dev->board].portd == SAA7164_MPEG_ENCODER) {
|
|
if (saa7164_encoder_register(&dev->ports[SAA7164_PORT_ENC2]) < 0) {
|
|
if (saa7164_encoder_register(&dev->ports[SAA7164_PORT_ENC2]) < 0) {
|
|
- printk(KERN_ERR"%s() Failed to register "
|
|
|
|
- "mpeg encoder\n", __func__);
|
|
|
|
|
|
+ printk(KERN_ERR"%s() Failed to register mpeg encoder\n",
|
|
|
|
+ __func__);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
if (saa7164_boards[dev->board].porte == SAA7164_MPEG_VBI) {
|
|
if (saa7164_boards[dev->board].porte == SAA7164_MPEG_VBI) {
|
|
if (saa7164_vbi_register(&dev->ports[SAA7164_PORT_VBI1]) < 0) {
|
|
if (saa7164_vbi_register(&dev->ports[SAA7164_PORT_VBI1]) < 0) {
|
|
- printk(KERN_ERR"%s() Failed to register "
|
|
|
|
- "vbi device\n", __func__);
|
|
|
|
|
|
+ printk(KERN_ERR"%s() Failed to register vbi device\n",
|
|
|
|
+ __func__);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
if (saa7164_boards[dev->board].portf == SAA7164_MPEG_VBI) {
|
|
if (saa7164_boards[dev->board].portf == SAA7164_MPEG_VBI) {
|
|
if (saa7164_vbi_register(&dev->ports[SAA7164_PORT_VBI2]) < 0) {
|
|
if (saa7164_vbi_register(&dev->ports[SAA7164_PORT_VBI2]) < 0) {
|
|
- printk(KERN_ERR"%s() Failed to register "
|
|
|
|
- "vbi device\n", __func__);
|
|
|
|
|
|
+ printk(KERN_ERR"%s() Failed to register vbi device\n",
|
|
|
|
+ __func__);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
saa7164_api_set_debug(dev, fw_debug);
|
|
saa7164_api_set_debug(dev, fw_debug);
|
|
@@ -1404,15 +1394,15 @@ static int saa7164_initdev(struct pci_dev *pci_dev,
|
|
"saa7164 debug");
|
|
"saa7164 debug");
|
|
if (IS_ERR(dev->kthread)) {
|
|
if (IS_ERR(dev->kthread)) {
|
|
dev->kthread = NULL;
|
|
dev->kthread = NULL;
|
|
- printk(KERN_ERR "%s() Failed to create "
|
|
|
|
- "debug kernel thread\n", __func__);
|
|
|
|
|
|
+ printk(KERN_ERR "%s() Failed to create debug kernel thread\n",
|
|
|
|
+ __func__);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
} /* != BOARD_UNKNOWN */
|
|
} /* != BOARD_UNKNOWN */
|
|
else
|
|
else
|
|
- printk(KERN_ERR "%s() Unsupported board detected, "
|
|
|
|
- "registering without firmware\n", __func__);
|
|
|
|
|
|
+ printk(KERN_ERR "%s() Unsupported board detected, registering without firmware\n",
|
|
|
|
+ __func__);
|
|
|
|
|
|
dprintk(1, "%s() parameter debug = %d\n", __func__, saa_debug);
|
|
dprintk(1, "%s() parameter debug = %d\n", __func__, saa_debug);
|
|
dprintk(1, "%s() parameter waitsecs = %d\n", __func__, waitsecs);
|
|
dprintk(1, "%s() parameter waitsecs = %d\n", __func__, waitsecs);
|