|
@@ -106,17 +106,9 @@ mtrr_write(struct file *file, const char __user *buf, size_t len, loff_t * ppos)
|
|
|
|
|
|
memset(line, 0, LINE_SIZE);
|
|
|
|
|
|
- length = len;
|
|
|
- length--;
|
|
|
-
|
|
|
- if (length > LINE_SIZE - 1)
|
|
|
- length = LINE_SIZE - 1;
|
|
|
-
|
|
|
+ length = strncpy_from_user(line, buf, LINE_SIZE - 1);
|
|
|
if (length < 0)
|
|
|
- return -EINVAL;
|
|
|
-
|
|
|
- if (copy_from_user(line, buf, length))
|
|
|
- return -EFAULT;
|
|
|
+ return length;
|
|
|
|
|
|
linelen = strlen(line);
|
|
|
ptr = line + linelen - 1;
|
|
@@ -149,17 +141,16 @@ mtrr_write(struct file *file, const char __user *buf, size_t len, loff_t * ppos)
|
|
|
return -EINVAL;
|
|
|
ptr = skip_spaces(ptr + 5);
|
|
|
|
|
|
- for (i = 0; i < MTRR_NUM_TYPES; ++i) {
|
|
|
- if (strcmp(ptr, mtrr_strings[i]))
|
|
|
- continue;
|
|
|
- base >>= PAGE_SHIFT;
|
|
|
- size >>= PAGE_SHIFT;
|
|
|
- err = mtrr_add_page((unsigned long)base, (unsigned long)size, i, true);
|
|
|
- if (err < 0)
|
|
|
- return err;
|
|
|
- return len;
|
|
|
- }
|
|
|
- return -EINVAL;
|
|
|
+ i = match_string(mtrr_strings, MTRR_NUM_TYPES, ptr);
|
|
|
+ if (i < 0)
|
|
|
+ return i;
|
|
|
+
|
|
|
+ base >>= PAGE_SHIFT;
|
|
|
+ size >>= PAGE_SHIFT;
|
|
|
+ err = mtrr_add_page((unsigned long)base, (unsigned long)size, i, true);
|
|
|
+ if (err < 0)
|
|
|
+ return err;
|
|
|
+ return len;
|
|
|
}
|
|
|
|
|
|
static long
|