瀏覽代碼

vmwgfx: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Reviewed-by: Jakob Bornecrantz <jakob@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Thomas Meyer 13 年之前
父節點
當前提交
24bb5a0ce3
共有 1 個文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c

+ 2 - 2
drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c

@@ -140,7 +140,7 @@ int vmw_present_ioctl(struct drm_device *dev, void *data,
 		goto out_clips;
 		goto out_clips;
 	}
 	}
 
 
-	clips = kzalloc(num_clips * sizeof(*clips), GFP_KERNEL);
+	clips = kcalloc(num_clips, sizeof(*clips), GFP_KERNEL);
 	if (clips == NULL) {
 	if (clips == NULL) {
 		DRM_ERROR("Failed to allocate clip rect list.\n");
 		DRM_ERROR("Failed to allocate clip rect list.\n");
 		ret = -ENOMEM;
 		ret = -ENOMEM;
@@ -232,7 +232,7 @@ int vmw_present_readback_ioctl(struct drm_device *dev, void *data,
 		goto out_clips;
 		goto out_clips;
 	}
 	}
 
 
-	clips = kzalloc(num_clips * sizeof(*clips), GFP_KERNEL);
+	clips = kcalloc(num_clips, sizeof(*clips), GFP_KERNEL);
 	if (clips == NULL) {
 	if (clips == NULL) {
 		DRM_ERROR("Failed to allocate clip rect list.\n");
 		DRM_ERROR("Failed to allocate clip rect list.\n");
 		ret = -ENOMEM;
 		ret = -ENOMEM;