Browse Source

amd-xgbe: Prevent Tx cleanup stall

When performing Tx cleanup, the dirty index counter is compared to the
current index counter as one of the tests used to determine when to stop
cleanup. The "less than" test will fail when the current index counter
rolls over to zero causing cleanup to never occur again. Update the test
to a "not equal" to avoid this situation.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Lendacky, Thomas 10 năm trước cách đây
mục cha
commit
244d62be91
1 tập tin đã thay đổi với 1 bổ sung1 xóa
  1. 1 1
      drivers/net/ethernet/amd/xgbe/xgbe-drv.c

+ 1 - 1
drivers/net/ethernet/amd/xgbe/xgbe-drv.c

@@ -1554,7 +1554,7 @@ static int xgbe_tx_poll(struct xgbe_channel *channel)
 	spin_lock_irqsave(&ring->lock, flags);
 
 	while ((processed < XGBE_TX_DESC_MAX_PROC) &&
-	       (ring->dirty < ring->cur)) {
+	       (ring->dirty != ring->cur)) {
 		rdata = XGBE_GET_DESC_DATA(ring, ring->dirty);
 		rdesc = rdata->rdesc;