Эх сурвалжийг харах

iwlagn: Improve aggregation failure error messages

82ca9341763107615a15da6e59b9535d49eb91c3 added scary looking
but harmless error messages.  Make them clearer and make the
actual failure message show up with the same severity as the
harmless one.

Signed-off-by: Andy Lutomirski <luto@mit.edu>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Andy Lutomirski 15 жил өмнө
parent
commit
2411054ae9

+ 7 - 4
drivers/net/wireless/iwlwifi/iwl-agn-rs.c

@@ -300,8 +300,9 @@ static int rs_tl_turn_on_agg_for_tid(struct iwl_priv *priv,
 				      struct ieee80211_sta *sta)
 				      struct ieee80211_sta *sta)
 {
 {
 	int ret = -EAGAIN;
 	int ret = -EAGAIN;
+	u32 load = rs_tl_get_load(lq_data, tid);
 
 
-	if (rs_tl_get_load(lq_data, tid) > IWL_AGG_LOAD_THRESHOLD) {
+	if (load > IWL_AGG_LOAD_THRESHOLD) {
 		IWL_DEBUG_HT(priv, "Starting Tx agg: STA: %pM tid: %d\n",
 		IWL_DEBUG_HT(priv, "Starting Tx agg: STA: %pM tid: %d\n",
 				sta->addr, tid);
 				sta->addr, tid);
 		ret = ieee80211_start_tx_ba_session(sta, tid);
 		ret = ieee80211_start_tx_ba_session(sta, tid);
@@ -311,12 +312,14 @@ static int rs_tl_turn_on_agg_for_tid(struct iwl_priv *priv,
 			 * this might be cause by reloading firmware
 			 * this might be cause by reloading firmware
 			 * stop the tx ba session here
 			 * stop the tx ba session here
 			 */
 			 */
-			IWL_DEBUG_HT(priv, "Fail start Tx agg on tid: %d\n",
+			IWL_ERR(priv, "Fail start Tx agg on tid: %d\n",
 				tid);
 				tid);
 			ieee80211_stop_tx_ba_session(sta, tid);
 			ieee80211_stop_tx_ba_session(sta, tid);
 		}
 		}
-	} else
-		IWL_ERR(priv, "Fail finding valid aggregation tid: %d\n", tid);
+	} else {
+		IWL_ERR(priv, "Aggregation not enabled for tid %d "
+			"because load = %u\n", tid, load);
+	}
 	return ret;
 	return ret;
 }
 }