Browse Source

RDMA/netlink: Reduce exposure of RDMA netlink functions

RDMA netlink is part of ib_core, hence ibnl_chk_listeners(),
ibnl_init() and ibnl_cleanup() don't need to be published
in public header file.

Let's remove EXPORT_SYMBOL from ibnl_chk_listeners() and move all these
functions to private header file.

CC: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Leon Romanovsky 8 years ago
parent
commit
233c195583

+ 10 - 0
drivers/infiniband/core/core_priv.h

@@ -169,6 +169,16 @@ void ib_mad_cleanup(void);
 int ib_sa_init(void);
 int ib_sa_init(void);
 void ib_sa_cleanup(void);
 void ib_sa_cleanup(void);
 
 
+int ibnl_init(void);
+void ibnl_cleanup(void);
+
+/**
+ * Check if there are any listeners to the netlink group
+ * @group: the netlink group ID
+ * Returns 0 on success or a negative for no listeners.
+ */
+int ibnl_chk_listeners(unsigned int group);
+
 int ib_nl_handle_resolve_resp(struct sk_buff *skb,
 int ib_nl_handle_resolve_resp(struct sk_buff *skb,
 			      struct netlink_callback *cb);
 			      struct netlink_callback *cb);
 int ib_nl_handle_set_timeout(struct sk_buff *skb,
 int ib_nl_handle_set_timeout(struct sk_buff *skb,

+ 1 - 1
drivers/infiniband/core/netlink.c

@@ -37,6 +37,7 @@
 #include <net/net_namespace.h>
 #include <net/net_namespace.h>
 #include <net/sock.h>
 #include <net/sock.h>
 #include <rdma/rdma_netlink.h>
 #include <rdma/rdma_netlink.h>
+#include "core_priv.h"
 
 
 struct ibnl_client {
 struct ibnl_client {
 	struct list_head		list;
 	struct list_head		list;
@@ -55,7 +56,6 @@ int ibnl_chk_listeners(unsigned int group)
 		return -1;
 		return -1;
 	return 0;
 	return 0;
 }
 }
-EXPORT_SYMBOL(ibnl_chk_listeners);
 
 
 int ibnl_add_client(int index, int nops,
 int ibnl_add_client(int index, int nops,
 		    const struct ibnl_client_cbs cb_table[])
 		    const struct ibnl_client_cbs cb_table[])

+ 0 - 10
include/rdma/rdma_netlink.h

@@ -10,9 +10,6 @@ struct ibnl_client_cbs {
 	struct module *module;
 	struct module *module;
 };
 };
 
 
-int ibnl_init(void);
-void ibnl_cleanup(void);
-
 /**
 /**
  * Add a a client to the list of IB netlink exporters.
  * Add a a client to the list of IB netlink exporters.
  * @index: Index of the added client
  * @index: Index of the added client
@@ -77,11 +74,4 @@ int ibnl_unicast(struct sk_buff *skb, struct nlmsghdr *nlh,
 int ibnl_multicast(struct sk_buff *skb, struct nlmsghdr *nlh,
 int ibnl_multicast(struct sk_buff *skb, struct nlmsghdr *nlh,
 			unsigned int group, gfp_t flags);
 			unsigned int group, gfp_t flags);
 
 
-/**
- * Check if there are any listeners to the netlink group
- * @group: the netlink group ID
- * Returns 0 on success or a negative for no listeners.
- */
-int ibnl_chk_listeners(unsigned int group);
-
 #endif /* _RDMA_NETLINK_H */
 #endif /* _RDMA_NETLINK_H */