Selaa lähdekoodia

Merge tag 'regmap-v3.17-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap

Pull regmap fix from Mark Brown:
 "Fix registers file in debugfs

  Ensure that the mode reported for the registers file in debugfs is
  accurate by marking it as read only when the define to enable writes
  has not been set.  This is on the edge of being a bug fix but it's
  debugfs and it makes it much easier for users to spot what's going
  wrong when they forget to enable writeability"

* tag 'regmap-v3.17-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap:
  regmap: Fix debugfs-file 'registers' mode
Linus Torvalds 11 vuotta sitten
vanhempi
commit
2324067fa9
1 muutettua tiedostoa jossa 8 lisäystä ja 1 poistoa
  1. 8 1
      drivers/base/regmap/regmap-debugfs.c

+ 8 - 1
drivers/base/regmap/regmap-debugfs.c

@@ -512,7 +512,14 @@ void regmap_debugfs_init(struct regmap *map, const char *name)
 			    map, &regmap_reg_ranges_fops);
 			    map, &regmap_reg_ranges_fops);
 
 
 	if (map->max_register || regmap_readable(map, 0)) {
 	if (map->max_register || regmap_readable(map, 0)) {
-		debugfs_create_file("registers", 0400, map->debugfs,
+		umode_t registers_mode;
+
+		if (IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS))
+			registers_mode = 0600;
+		else
+			registers_mode = 0400;
+
+		debugfs_create_file("registers", registers_mode, map->debugfs,
 				    map, &regmap_map_fops);
 				    map, &regmap_map_fops);
 		debugfs_create_file("access", 0400, map->debugfs,
 		debugfs_create_file("access", 0400, map->debugfs,
 				    map, &regmap_access_fops);
 				    map, &regmap_access_fops);