Browse Source

target: Remove unneeded check in sbc_parse_cdb

The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's
refactoring of this function. There are no places where that flag is set
that cmd->execute_cmd isn't also set.

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Andy Grover 11 years ago
parent
commit
20959c4b40
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/target/target_core_sbc.c

+ 1 - 1
drivers/target/target_core_sbc.c

@@ -948,7 +948,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
 	}
 	}
 
 
 	/* reject any command that we don't have a handler for */
 	/* reject any command that we don't have a handler for */
-	if (!(cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) && !cmd->execute_cmd)
+	if (!cmd->execute_cmd)
 		return TCM_UNSUPPORTED_SCSI_OPCODE;
 		return TCM_UNSUPPORTED_SCSI_OPCODE;
 
 
 	if (cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) {
 	if (cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) {