Ver Fonte

net: fs_enet: Fix an error handling path

'of_node_put(fpi->phy_node)' should also be called if we branch to
'out_deregister_fixed_link' error handling path.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Christophe Jaillet há 8 anos atrás
pai
commit
1f8f1e89e0
1 ficheiros alterados com 1 adições e 1 exclusões
  1. 1 1
      drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c

+ 1 - 1
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c

@@ -1045,10 +1045,10 @@ out_cleanup_data:
 out_free_dev:
 out_free_dev:
 	free_netdev(ndev);
 	free_netdev(ndev);
 out_put:
 out_put:
-	of_node_put(fpi->phy_node);
 	if (fpi->clk_per)
 	if (fpi->clk_per)
 		clk_disable_unprepare(fpi->clk_per);
 		clk_disable_unprepare(fpi->clk_per);
 out_deregister_fixed_link:
 out_deregister_fixed_link:
+	of_node_put(fpi->phy_node);
 	if (of_phy_is_fixed_link(ofdev->dev.of_node))
 	if (of_phy_is_fixed_link(ofdev->dev.of_node))
 		of_phy_deregister_fixed_link(ofdev->dev.of_node);
 		of_phy_deregister_fixed_link(ofdev->dev.of_node);
 out_free_fpi:
 out_free_fpi: