Эх сурвалжийг харах

xfs: check _btree_check_block value

Check the _btree_check_block return value for the firstrec and lastrec
functions, since we have the ability to signal that the repositioning
did not succeed.

Fixes-coverity-id: 114067
Fixes-coverity-id: 114068
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Darrick J. Wong 8 жил өмнө
parent
commit
1e86eabe73

+ 4 - 2
fs/xfs/libxfs/xfs_btree.c

@@ -728,7 +728,8 @@ xfs_btree_firstrec(
 	 * Get the block pointer for this level.
 	 * Get the block pointer for this level.
 	 */
 	 */
 	block = xfs_btree_get_block(cur, level, &bp);
 	block = xfs_btree_get_block(cur, level, &bp);
-	xfs_btree_check_block(cur, block, level, bp);
+	if (xfs_btree_check_block(cur, block, level, bp))
+		return 0;
 	/*
 	/*
 	 * It's empty, there is no such record.
 	 * It's empty, there is no such record.
 	 */
 	 */
@@ -757,7 +758,8 @@ xfs_btree_lastrec(
 	 * Get the block pointer for this level.
 	 * Get the block pointer for this level.
 	 */
 	 */
 	block = xfs_btree_get_block(cur, level, &bp);
 	block = xfs_btree_get_block(cur, level, &bp);
-	xfs_btree_check_block(cur, block, level, bp);
+	if (xfs_btree_check_block(cur, block, level, bp))
+		return 0;
 	/*
 	/*
 	 * It's empty, there is no such record.
 	 * It's empty, there is no such record.
 	 */
 	 */