Преглед изворни кода

nfp: fix TLV offset calculation

The data pointer in the config space TLV parser already includes
NFP_NET_CFG_TLV_BASE, it should not be added again. Incorrect
offset values were only used in printed user output, rendering
the bug merely cosmetic.

Fixes: 73a0329b057e ("nfp: add TLV capabilities to the BAR")
Signed-off-by: Edwin Peer <edwin.peer@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Edwin Peer пре 7 година
родитељ
комит
1d8ef0c076
1 измењених фајлова са 1 додато и 1 уклоњено
  1. 1 1
      drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c

+ 1 - 1
drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c

@@ -65,7 +65,7 @@ int nfp_net_tlv_caps_parse(struct device *dev, u8 __iomem *ctrl_mem,
 		u32 hdr = readl(data);
 		u32 hdr = readl(data);
 
 
 		length = FIELD_GET(NFP_NET_CFG_TLV_HEADER_LENGTH, hdr);
 		length = FIELD_GET(NFP_NET_CFG_TLV_HEADER_LENGTH, hdr);
-		offset = data - ctrl_mem + NFP_NET_CFG_TLV_BASE;
+		offset = data - ctrl_mem;
 
 
 		/* Advance past the header */
 		/* Advance past the header */
 		data += 4;
 		data += 4;