浏览代码

drm/imx: dw_hdmi: Don't call platform_set_drvdata()

The IMX dw_hdmi driver just called platform_set_drvdata() to get
your hopes up that maybe, somehow, you'd be able to retrieve the 'struct
imx_hdmi' from a pointer to the 'struct device'.  You can't.  When
we call dw_hdmi_bind() the main driver calls dev_set_drvdata(), which
clobbers our setting.

Let's just remove the platform_set_drvdata() to avoid dashing people's
hopes.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Douglas Anderson 9 年之前
父节点
当前提交
1cc9daea2a
共有 1 个文件被更改,包括 0 次插入2 次删除
  1. 0 2
      drivers/gpu/drm/imx/dw_hdmi-imx.c

+ 0 - 2
drivers/gpu/drm/imx/dw_hdmi-imx.c

@@ -225,8 +225,6 @@ static int dw_hdmi_imx_bind(struct device *dev, struct device *master,
 	if (!iores)
 		return -ENXIO;
 
-	platform_set_drvdata(pdev, hdmi);
-
 	encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node);
 	/*
 	 * If we failed to find the CRTC(s) which this encoder is