|
@@ -1011,7 +1011,7 @@ static struct dep_stack {
|
|
|
struct dep_stack *prev, *next;
|
|
|
struct symbol *sym;
|
|
|
struct property *prop;
|
|
|
- struct expr *expr;
|
|
|
+ struct expr **expr;
|
|
|
} *check_top;
|
|
|
|
|
|
static void dep_stack_insert(struct dep_stack *stack, struct symbol *sym)
|
|
@@ -1076,31 +1076,42 @@ static void sym_check_print_recursive(struct symbol *last_sym)
|
|
|
fprintf(stderr, "%s:%d:error: recursive dependency detected!\n",
|
|
|
prop->file->name, prop->lineno);
|
|
|
|
|
|
- if (stack->expr) {
|
|
|
- fprintf(stderr, "%s:%d:\tsymbol %s %s value contains %s\n",
|
|
|
- prop->file->name, prop->lineno,
|
|
|
+ if (sym_is_choice(sym)) {
|
|
|
+ fprintf(stderr, "%s:%d:\tchoice %s contains symbol %s\n",
|
|
|
+ menu->file->name, menu->lineno,
|
|
|
sym->name ? sym->name : "<choice>",
|
|
|
- prop_get_type_name(prop->type),
|
|
|
next_sym->name ? next_sym->name : "<choice>");
|
|
|
- } else if (stack->prop) {
|
|
|
+ } else if (sym_is_choice_value(sym)) {
|
|
|
+ fprintf(stderr, "%s:%d:\tsymbol %s is part of choice %s\n",
|
|
|
+ menu->file->name, menu->lineno,
|
|
|
+ sym->name ? sym->name : "<choice>",
|
|
|
+ next_sym->name ? next_sym->name : "<choice>");
|
|
|
+ } else if (stack->expr == &sym->dir_dep.expr) {
|
|
|
fprintf(stderr, "%s:%d:\tsymbol %s depends on %s\n",
|
|
|
prop->file->name, prop->lineno,
|
|
|
sym->name ? sym->name : "<choice>",
|
|
|
next_sym->name ? next_sym->name : "<choice>");
|
|
|
- } else if (sym_is_choice(sym)) {
|
|
|
- fprintf(stderr, "%s:%d:\tchoice %s contains symbol %s\n",
|
|
|
- menu->file->name, menu->lineno,
|
|
|
+ } else if (stack->expr == &sym->rev_dep.expr) {
|
|
|
+ fprintf(stderr, "%s:%d:\tsymbol %s is selected by %s\n",
|
|
|
+ prop->file->name, prop->lineno,
|
|
|
sym->name ? sym->name : "<choice>",
|
|
|
next_sym->name ? next_sym->name : "<choice>");
|
|
|
- } else if (sym_is_choice_value(sym)) {
|
|
|
- fprintf(stderr, "%s:%d:\tsymbol %s is part of choice %s\n",
|
|
|
- menu->file->name, menu->lineno,
|
|
|
+ } else if (stack->expr == &sym->implied.expr) {
|
|
|
+ fprintf(stderr, "%s:%d:\tsymbol %s is implied by %s\n",
|
|
|
+ prop->file->name, prop->lineno,
|
|
|
+ sym->name ? sym->name : "<choice>",
|
|
|
+ next_sym->name ? next_sym->name : "<choice>");
|
|
|
+ } else if (stack->expr) {
|
|
|
+ fprintf(stderr, "%s:%d:\tsymbol %s %s value contains %s\n",
|
|
|
+ prop->file->name, prop->lineno,
|
|
|
sym->name ? sym->name : "<choice>",
|
|
|
+ prop_get_type_name(prop->type),
|
|
|
next_sym->name ? next_sym->name : "<choice>");
|
|
|
} else {
|
|
|
- fprintf(stderr, "%s:%d:\tsymbol %s is selected by %s\n",
|
|
|
+ fprintf(stderr, "%s:%d:\tsymbol %s %s is visible depending on %s\n",
|
|
|
prop->file->name, prop->lineno,
|
|
|
sym->name ? sym->name : "<choice>",
|
|
|
+ prop_get_type_name(prop->type),
|
|
|
next_sym->name ? next_sym->name : "<choice>");
|
|
|
}
|
|
|
}
|
|
@@ -1157,12 +1168,26 @@ static struct symbol *sym_check_sym_deps(struct symbol *sym)
|
|
|
|
|
|
dep_stack_insert(&stack, sym);
|
|
|
|
|
|
+ stack.expr = &sym->dir_dep.expr;
|
|
|
+ sym2 = sym_check_expr_deps(sym->dir_dep.expr);
|
|
|
+ if (sym2)
|
|
|
+ goto out;
|
|
|
+
|
|
|
+ stack.expr = &sym->rev_dep.expr;
|
|
|
sym2 = sym_check_expr_deps(sym->rev_dep.expr);
|
|
|
if (sym2)
|
|
|
goto out;
|
|
|
|
|
|
+ stack.expr = &sym->implied.expr;
|
|
|
+ sym2 = sym_check_expr_deps(sym->implied.expr);
|
|
|
+ if (sym2)
|
|
|
+ goto out;
|
|
|
+
|
|
|
+ stack.expr = NULL;
|
|
|
+
|
|
|
for (prop = sym->prop; prop; prop = prop->next) {
|
|
|
- if (prop->type == P_CHOICE || prop->type == P_SELECT)
|
|
|
+ if (prop->type == P_CHOICE || prop->type == P_SELECT ||
|
|
|
+ prop->type == P_IMPLY)
|
|
|
continue;
|
|
|
stack.prop = prop;
|
|
|
sym2 = sym_check_expr_deps(prop->visible.expr);
|
|
@@ -1170,7 +1195,7 @@ static struct symbol *sym_check_sym_deps(struct symbol *sym)
|
|
|
break;
|
|
|
if (prop->type != P_DEFAULT || sym_is_choice(sym))
|
|
|
continue;
|
|
|
- stack.expr = prop->expr;
|
|
|
+ stack.expr = &prop->expr;
|
|
|
sym2 = sym_check_expr_deps(prop->expr);
|
|
|
if (sym2)
|
|
|
break;
|
|
@@ -1248,9 +1273,6 @@ struct symbol *sym_check_deps(struct symbol *sym)
|
|
|
sym->flags &= ~SYMBOL_CHECK;
|
|
|
}
|
|
|
|
|
|
- if (sym2 && sym2 == sym)
|
|
|
- sym2 = NULL;
|
|
|
-
|
|
|
return sym2;
|
|
|
}
|
|
|
|