소스 검색

drivers/macintosh: Make wf_control_ops and wf_pid_param const

Make wf_control_ops const as they are only stored in the ops field of a
wf_control structure, which is const.
Make wf_pid_param const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Bhumika Goyal 8 년 전
부모
커밋
1ad35f6e28
3개의 변경된 파일4개의 추가작업 그리고 4개의 파일을 삭제
  1. 1 1
      drivers/macintosh/windfarm_cpufreq_clamp.c
  2. 2 2
      drivers/macintosh/windfarm_rm31.c
  3. 1 1
      drivers/macintosh/windfarm_smu_controls.c

+ 1 - 1
drivers/macintosh/windfarm_cpufreq_clamp.c

@@ -63,7 +63,7 @@ static s32 clamp_max(struct wf_control *ct)
 	return 1;
 	return 1;
 }
 }
 
 
-static struct wf_control_ops clamp_ops = {
+static const struct wf_control_ops clamp_ops = {
 	.set_value	= clamp_set,
 	.set_value	= clamp_set,
 	.get_value	= clamp_get,
 	.get_value	= clamp_get,
 	.get_min	= clamp_min,
 	.get_min	= clamp_min,

+ 2 - 2
drivers/macintosh/windfarm_rm31.c

@@ -338,7 +338,7 @@ static int cpu_setup_pid(int cpu)
 }
 }
 
 
 /* Backside/U3 fan */
 /* Backside/U3 fan */
-static struct wf_pid_param backside_param = {
+static const struct wf_pid_param backside_param = {
 	.interval	= 1,
 	.interval	= 1,
 	.history_len	= 2,
 	.history_len	= 2,
 	.gd		= 0x00500000,
 	.gd		= 0x00500000,
@@ -351,7 +351,7 @@ static struct wf_pid_param backside_param = {
 };
 };
 
 
 /* DIMMs temperature (clamp the backside fan) */
 /* DIMMs temperature (clamp the backside fan) */
-static struct wf_pid_param dimms_param = {
+static const struct wf_pid_param dimms_param = {
 	.interval	= 1,
 	.interval	= 1,
 	.history_len	= 20,
 	.history_len	= 20,
 	.gd		= 0,
 	.gd		= 0,

+ 1 - 1
drivers/macintosh/windfarm_smu_controls.c

@@ -145,7 +145,7 @@ static s32 smu_fan_max(struct wf_control *ct)
 	return fct->max;
 	return fct->max;
 }
 }
 
 
-static struct wf_control_ops smu_fan_ops = {
+static const struct wf_control_ops smu_fan_ops = {
 	.set_value	= smu_fan_set,
 	.set_value	= smu_fan_set,
 	.get_value	= smu_fan_get,
 	.get_value	= smu_fan_get,
 	.get_min	= smu_fan_min,
 	.get_min	= smu_fan_min,