Răsfoiți Sursa

pinctrl: freescale: off by one in imx1_pinconf_group_dbg_show()

The info->groups[] array is allocated in imx1_pinctrl_parse_dt().  It
has info->ngroups elements.  Thus the > here should be >= to prevent
reading one element beyond the end of the array.

Cc: stable@vger.kernel.org
Fixes: 30612cd90005 ("pinctrl: imx1 core driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Uwe Kleine-König <u.kleine-könig@pengutronix.de>
Acked-by: Dong Aisheng <Aisheng.dong@nxp.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Dan Carpenter 7 ani în urmă
părinte
comite
19da44cd33
1 a modificat fișierele cu 1 adăugiri și 1 ștergeri
  1. 1 1
      drivers/pinctrl/freescale/pinctrl-imx1-core.c

+ 1 - 1
drivers/pinctrl/freescale/pinctrl-imx1-core.c

@@ -429,7 +429,7 @@ static void imx1_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
 	const char *name;
 	int i, ret;
 
-	if (group > info->ngroups)
+	if (group >= info->ngroups)
 		return;
 
 	seq_puts(s, "\n");