瀏覽代碼

regmap: Fix debugfs-file 'registers' mode

The macro "REGMAP_ALLOW_WRITE_DEBUGFS" can be used to enable write
support on the registers file in the debugfs. The mode of the file is
fixed to 0400 so it is not possible to write the file ever.

This patch fixes the mode by setting it to the correct value depending
on the macro.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Markus Pargmann 11 年之前
父節點
當前提交
18c0301f98
共有 1 個文件被更改,包括 8 次插入1 次删除
  1. 8 1
      drivers/base/regmap/regmap-debugfs.c

+ 8 - 1
drivers/base/regmap/regmap-debugfs.c

@@ -516,7 +516,14 @@ void regmap_debugfs_init(struct regmap *map, const char *name)
 			    map, &regmap_reg_ranges_fops);
 			    map, &regmap_reg_ranges_fops);
 
 
 	if (map->max_register || regmap_readable(map, 0)) {
 	if (map->max_register || regmap_readable(map, 0)) {
-		debugfs_create_file("registers", 0400, map->debugfs,
+		umode_t registers_mode;
+
+		if (IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS))
+			registers_mode = 0600;
+		else
+			registers_mode = 0400;
+
+		debugfs_create_file("registers", registers_mode, map->debugfs,
 				    map, &regmap_map_fops);
 				    map, &regmap_map_fops);
 		debugfs_create_file("access", 0400, map->debugfs,
 		debugfs_create_file("access", 0400, map->debugfs,
 				    map, &regmap_access_fops);
 				    map, &regmap_access_fops);