소스 검색

usb: gadget: u_serial: eliminate abuse of ep->driver data

Since ep->driver_data is not used for endpoint claiming, neither for
enabled/disabled state storing, we can reduce number of places where
we read or modify it's value, as now it has no particular meaning for
function or framework logic.

In case of u_serial ep->driver_data stores pointer to struct gs_port,
which is referenced in many places in code. Code using ep->driver_data
to mark endpoint as enabled/disabled has been removed.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Robert Baldyga 10 년 전
부모
커밋
18411c0f94
1개의 변경된 파일0개의 추가작업 그리고 5개의 파일을 삭제
  1. 0 5
      drivers/usb/gadget/function/u_serial.c

+ 0 - 5
drivers/usb/gadget/function/u_serial.c

@@ -876,7 +876,6 @@ static void gs_close(struct tty_struct *tty, struct file *file)
 	else
 	else
 		gs_buf_clear(&port->port_write_buf);
 		gs_buf_clear(&port->port_write_buf);
 
 
-	tty->driver_data = NULL;
 	port->port.tty = NULL;
 	port->port.tty = NULL;
 
 
 	port->openclose = false;
 	port->openclose = false;
@@ -1224,7 +1223,6 @@ int gserial_connect(struct gserial *gser, u8 port_num)
 
 
 fail_out:
 fail_out:
 	usb_ep_disable(gser->in);
 	usb_ep_disable(gser->in);
-	gser->in->driver_data = NULL;
 	return status;
 	return status;
 }
 }
 EXPORT_SYMBOL_GPL(gserial_connect);
 EXPORT_SYMBOL_GPL(gserial_connect);
@@ -1264,10 +1262,7 @@ void gserial_disconnect(struct gserial *gser)
 
 
 	/* disable endpoints, aborting down any active I/O */
 	/* disable endpoints, aborting down any active I/O */
 	usb_ep_disable(gser->out);
 	usb_ep_disable(gser->out);
-	gser->out->driver_data = NULL;
-
 	usb_ep_disable(gser->in);
 	usb_ep_disable(gser->in);
-	gser->in->driver_data = NULL;
 
 
 	/* finally, free any unused/unusable I/O buffers */
 	/* finally, free any unused/unusable I/O buffers */
 	spin_lock_irqsave(&port->port_lock, flags);
 	spin_lock_irqsave(&port->port_lock, flags);