浏览代码

configfs: replace strncpy with memcpy

gcc 8.1.0 complains:

fs/configfs/symlink.c:67:3: warning:
	'strncpy' output truncated before terminating nul copying as many
	bytes from a string as its length
fs/configfs/symlink.c: In function 'configfs_get_link':
fs/configfs/symlink.c:63:13: note: length computed here

Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Guenter Roeck 7 年之前
父节点
当前提交
1823342a1f
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      fs/configfs/symlink.c

+ 1 - 1
fs/configfs/symlink.c

@@ -64,7 +64,7 @@ static void fill_item_path(struct config_item * item, char * buffer, int length)
 
 
 		/* back up enough to print this bus id with '/' */
 		/* back up enough to print this bus id with '/' */
 		length -= cur;
 		length -= cur;
-		strncpy(buffer + length,config_item_name(p),cur);
+		memcpy(buffer + length, config_item_name(p), cur);
 		*(buffer + --length) = '/';
 		*(buffer + --length) = '/';
 	}
 	}
 }
 }