浏览代码

rcu: Consolidate expedited GP tracing into rcu_exp_gp_seq_snap()

This commit moves some duplicate code from synchronize_rcu_expedited()
and synchronize_sched_expedited() into rcu_exp_gp_seq_snap().  This
doesn't save lines of code, but does eliminate a "tell me twice" issue.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Paul E. McKenney 9 年之前
父节点
当前提交
179e5dcd1e
共有 2 个文件被更改,包括 5 次插入5 次删除
  1. 5 3
      kernel/rcu/tree.c
  2. 0 2
      kernel/rcu/tree_plugin.h

+ 5 - 3
kernel/rcu/tree.c

@@ -3392,8 +3392,12 @@ static void rcu_exp_gp_seq_end(struct rcu_state *rsp)
 }
 }
 static unsigned long rcu_exp_gp_seq_snap(struct rcu_state *rsp)
 static unsigned long rcu_exp_gp_seq_snap(struct rcu_state *rsp)
 {
 {
+	unsigned long s;
+
 	smp_mb(); /* Caller's modifications seen first by other CPUs. */
 	smp_mb(); /* Caller's modifications seen first by other CPUs. */
-	return rcu_seq_snap(&rsp->expedited_sequence);
+	s = rcu_seq_snap(&rsp->expedited_sequence);
+	trace_rcu_exp_grace_period(rsp->name, s, TPS("snap"));
+	return s;
 }
 }
 static bool rcu_exp_gp_seq_done(struct rcu_state *rsp, unsigned long s)
 static bool rcu_exp_gp_seq_done(struct rcu_state *rsp, unsigned long s)
 {
 {
@@ -3898,8 +3902,6 @@ void synchronize_sched_expedited(void)
 
 
 	/* Take a snapshot of the sequence number.  */
 	/* Take a snapshot of the sequence number.  */
 	s = rcu_exp_gp_seq_snap(rsp);
 	s = rcu_exp_gp_seq_snap(rsp);
-	trace_rcu_exp_grace_period(rsp->name, s, TPS("snap"));
-
 	if (exp_funnel_lock(rsp, s))
 	if (exp_funnel_lock(rsp, s))
 		return;  /* Someone else did our work for us. */
 		return;  /* Someone else did our work for us. */
 
 

+ 0 - 2
kernel/rcu/tree_plugin.h

@@ -748,8 +748,6 @@ void synchronize_rcu_expedited(void)
 	}
 	}
 
 
 	s = rcu_exp_gp_seq_snap(rsp);
 	s = rcu_exp_gp_seq_snap(rsp);
-	trace_rcu_exp_grace_period(rsp->name, s, TPS("snap"));
-
 	if (exp_funnel_lock(rsp, s))
 	if (exp_funnel_lock(rsp, s))
 		return;  /* Someone else did our work for us. */
 		return;  /* Someone else did our work for us. */