Browse Source

regmap: debugfs: Don't bother actually printing when calculating max length

The in kernel snprintf() will conveniently return the actual length of
the printed string even if not given an output beffer at all so just do
that rather than relying on the user to pass in a suitable buffer,
ensuring that we don't need to worry if the buffer was truncated due to
the size of the buffer passed in.

Reported-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Mark Brown 10 years ago
parent
commit
176fc2d577
1 changed files with 1 additions and 2 deletions
  1. 1 2
      drivers/base/regmap/regmap-debugfs.c

+ 1 - 2
drivers/base/regmap/regmap-debugfs.c

@@ -32,8 +32,7 @@ static DEFINE_MUTEX(regmap_debugfs_early_lock);
 /* Calculate the length of a fixed format  */
 /* Calculate the length of a fixed format  */
 static size_t regmap_calc_reg_len(int max_val, char *buf, size_t buf_size)
 static size_t regmap_calc_reg_len(int max_val, char *buf, size_t buf_size)
 {
 {
-	snprintf(buf, buf_size, "%x", max_val);
-	return strlen(buf);
+	return snprintf(NULL, 0, "%x", max_val);
 }
 }
 
 
 static ssize_t regmap_name_read_file(struct file *file,
 static ssize_t regmap_name_read_file(struct file *file,