Browse Source

arm64: ptrace: Remove redundant overrun check from compat_vfp_set()

compat_vfp_set() checks for userspace trying to write an excessive
amount of data to the regset.  However this check is conspicuous
for its absence from every other _set() in the arm64 ptrace
implementation.  In fact, the core ptrace_regset() already clamps
userspace's iov_len to the regset size before the individual regset
.{get,set}() methods get called.

This patch removes the redundant check.

Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Dave Martin 8 years ago
parent
commit
16d38acb12
1 changed files with 0 additions and 3 deletions
  1. 0 3
      arch/arm64/kernel/ptrace.c

+ 0 - 3
arch/arm64/kernel/ptrace.c

@@ -937,9 +937,6 @@ static int compat_vfp_set(struct task_struct *target,
 	compat_ulong_t fpscr;
 	compat_ulong_t fpscr;
 	int ret;
 	int ret;
 
 
-	if (pos + count > VFP_STATE_SIZE)
-		return -EIO;
-
 	uregs = &target->thread.fpsimd_state.user_fpsimd;
 	uregs = &target->thread.fpsimd_state.user_fpsimd;
 
 
 	ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, uregs, 0,
 	ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, uregs, 0,