Просмотр исходного кода

tracing: Deletion of an unnecessary check before iput()

The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Link: http://lkml.kernel.org/r/5468F875.7080907@users.sourceforge.net

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Markus Elfring 11 лет назад
Родитель
Сommit
16a8ef2751
1 измененных файлов с 1 добавлено и 2 удалено
  1. 1 2
      kernel/trace/trace_uprobe.c

+ 1 - 2
kernel/trace/trace_uprobe.c

@@ -552,8 +552,7 @@ static int create_trace_uprobe(int argc, char **argv)
 	return ret;
 
 fail_address_parse:
-	if (inode)
-		iput(inode);
+	iput(inode);
 
 	pr_info("Failed to parse address or file.\n");