|
@@ -57,21 +57,21 @@ static int vc4_get_param_ioctl(struct drm_device *dev, void *data,
|
|
switch (args->param) {
|
|
switch (args->param) {
|
|
case DRM_VC4_PARAM_V3D_IDENT0:
|
|
case DRM_VC4_PARAM_V3D_IDENT0:
|
|
ret = pm_runtime_get_sync(&vc4->v3d->pdev->dev);
|
|
ret = pm_runtime_get_sync(&vc4->v3d->pdev->dev);
|
|
- if (ret)
|
|
|
|
|
|
+ if (ret < 0)
|
|
return ret;
|
|
return ret;
|
|
args->value = V3D_READ(V3D_IDENT0);
|
|
args->value = V3D_READ(V3D_IDENT0);
|
|
pm_runtime_put(&vc4->v3d->pdev->dev);
|
|
pm_runtime_put(&vc4->v3d->pdev->dev);
|
|
break;
|
|
break;
|
|
case DRM_VC4_PARAM_V3D_IDENT1:
|
|
case DRM_VC4_PARAM_V3D_IDENT1:
|
|
ret = pm_runtime_get_sync(&vc4->v3d->pdev->dev);
|
|
ret = pm_runtime_get_sync(&vc4->v3d->pdev->dev);
|
|
- if (ret)
|
|
|
|
|
|
+ if (ret < 0)
|
|
return ret;
|
|
return ret;
|
|
args->value = V3D_READ(V3D_IDENT1);
|
|
args->value = V3D_READ(V3D_IDENT1);
|
|
pm_runtime_put(&vc4->v3d->pdev->dev);
|
|
pm_runtime_put(&vc4->v3d->pdev->dev);
|
|
break;
|
|
break;
|
|
case DRM_VC4_PARAM_V3D_IDENT2:
|
|
case DRM_VC4_PARAM_V3D_IDENT2:
|
|
ret = pm_runtime_get_sync(&vc4->v3d->pdev->dev);
|
|
ret = pm_runtime_get_sync(&vc4->v3d->pdev->dev);
|
|
- if (ret)
|
|
|
|
|
|
+ if (ret < 0)
|
|
return ret;
|
|
return ret;
|
|
args->value = V3D_READ(V3D_IDENT2);
|
|
args->value = V3D_READ(V3D_IDENT2);
|
|
pm_runtime_put(&vc4->v3d->pdev->dev);
|
|
pm_runtime_put(&vc4->v3d->pdev->dev);
|