Browse Source

drm/amdgpu/powerplay: fix missing break in switch statements

There are several switch statements that are missing break statements.
Add missing breaks to handle any fall-throughs corner cases.

Detected by CoverityScan, CID#1457175 ("Missing break in switch")

Fixes: 18aafc59b106 ("drm/amd/powerplay: implement fw related smu interface for iceland.")
Acked-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Colin Ian King 6 years ago
parent
commit
14b284832e

+ 2 - 0
drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c

@@ -2269,11 +2269,13 @@ static uint32_t ci_get_offsetof(uint32_t type, uint32_t member)
 		case DRAM_LOG_BUFF_SIZE:
 		case DRAM_LOG_BUFF_SIZE:
 			return offsetof(SMU7_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 			return offsetof(SMU7_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 		}
 		}
+		break;
 	case SMU_Discrete_DpmTable:
 	case SMU_Discrete_DpmTable:
 		switch (member) {
 		switch (member) {
 		case LowSclkInterruptThreshold:
 		case LowSclkInterruptThreshold:
 			return offsetof(SMU7_Discrete_DpmTable, LowSclkInterruptT);
 			return offsetof(SMU7_Discrete_DpmTable, LowSclkInterruptT);
 		}
 		}
+		break;
 	}
 	}
 	pr_debug("can't get the offset of type %x member %x\n", type, member);
 	pr_debug("can't get the offset of type %x member %x\n", type, member);
 	return 0;
 	return 0;

+ 2 - 0
drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c

@@ -2321,6 +2321,7 @@ static uint32_t fiji_get_offsetof(uint32_t type, uint32_t member)
 		case DRAM_LOG_BUFF_SIZE:
 		case DRAM_LOG_BUFF_SIZE:
 			return offsetof(SMU73_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 			return offsetof(SMU73_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 		}
 		}
+		break;
 	case SMU_Discrete_DpmTable:
 	case SMU_Discrete_DpmTable:
 		switch (member) {
 		switch (member) {
 		case UvdBootLevel:
 		case UvdBootLevel:
@@ -2330,6 +2331,7 @@ static uint32_t fiji_get_offsetof(uint32_t type, uint32_t member)
 		case LowSclkInterruptThreshold:
 		case LowSclkInterruptThreshold:
 			return offsetof(SMU73_Discrete_DpmTable, LowSclkInterruptThreshold);
 			return offsetof(SMU73_Discrete_DpmTable, LowSclkInterruptThreshold);
 		}
 		}
+		break;
 	}
 	}
 	pr_warn("can't get the offset of type %x member %x\n", type, member);
 	pr_warn("can't get the offset of type %x member %x\n", type, member);
 	return 0;
 	return 0;

+ 2 - 0
drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c

@@ -2236,11 +2236,13 @@ static uint32_t iceland_get_offsetof(uint32_t type, uint32_t member)
 		case DRAM_LOG_BUFF_SIZE:
 		case DRAM_LOG_BUFF_SIZE:
 			return offsetof(SMU71_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 			return offsetof(SMU71_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 		}
 		}
+		break;
 	case SMU_Discrete_DpmTable:
 	case SMU_Discrete_DpmTable:
 		switch (member) {
 		switch (member) {
 		case LowSclkInterruptThreshold:
 		case LowSclkInterruptThreshold:
 			return offsetof(SMU71_Discrete_DpmTable, LowSclkInterruptThreshold);
 			return offsetof(SMU71_Discrete_DpmTable, LowSclkInterruptThreshold);
 		}
 		}
+		break;
 	}
 	}
 	pr_warn("can't get the offset of type %x member %x\n", type, member);
 	pr_warn("can't get the offset of type %x member %x\n", type, member);
 	return 0;
 	return 0;

+ 2 - 0
drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c

@@ -2628,6 +2628,7 @@ static uint32_t tonga_get_offsetof(uint32_t type, uint32_t member)
 		case DRAM_LOG_BUFF_SIZE:
 		case DRAM_LOG_BUFF_SIZE:
 			return offsetof(SMU72_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 			return offsetof(SMU72_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 		}
 		}
+		break;
 	case SMU_Discrete_DpmTable:
 	case SMU_Discrete_DpmTable:
 		switch (member) {
 		switch (member) {
 		case UvdBootLevel:
 		case UvdBootLevel:
@@ -2637,6 +2638,7 @@ static uint32_t tonga_get_offsetof(uint32_t type, uint32_t member)
 		case LowSclkInterruptThreshold:
 		case LowSclkInterruptThreshold:
 			return offsetof(SMU72_Discrete_DpmTable, LowSclkInterruptThreshold);
 			return offsetof(SMU72_Discrete_DpmTable, LowSclkInterruptThreshold);
 		}
 		}
+		break;
 	}
 	}
 	pr_warn("can't get the offset of type %x member %x\n", type, member);
 	pr_warn("can't get the offset of type %x member %x\n", type, member);
 	return 0;
 	return 0;

+ 2 - 0
drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c

@@ -2185,6 +2185,7 @@ static uint32_t vegam_get_offsetof(uint32_t type, uint32_t member)
 		case DRAM_LOG_BUFF_SIZE:
 		case DRAM_LOG_BUFF_SIZE:
 			return offsetof(SMU75_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 			return offsetof(SMU75_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 		}
 		}
+		break;
 	case SMU_Discrete_DpmTable:
 	case SMU_Discrete_DpmTable:
 		switch (member) {
 		switch (member) {
 		case UvdBootLevel:
 		case UvdBootLevel:
@@ -2194,6 +2195,7 @@ static uint32_t vegam_get_offsetof(uint32_t type, uint32_t member)
 		case LowSclkInterruptThreshold:
 		case LowSclkInterruptThreshold:
 			return offsetof(SMU75_Discrete_DpmTable, LowSclkInterruptThreshold);
 			return offsetof(SMU75_Discrete_DpmTable, LowSclkInterruptThreshold);
 		}
 		}
+		break;
 	}
 	}
 	pr_warn("can't get the offset of type %x member %x\n", type, member);
 	pr_warn("can't get the offset of type %x member %x\n", type, member);
 	return 0;
 	return 0;