فهرست منبع

memstick: mspro_block: add missing curly braces

Using the indenting we can see the curly braces were obviously intended.
This is a static checker fix, but my guess is that we don't read enough
bytes, because we don't calculate "t_len" correctly.

Fixes: f1d82698029b ('memstick: use fully asynchronous request processing')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alex Dubov <oakad@yahoo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Dan Carpenter 10 سال پیش
والد
کامیت
13f6b191aa
1فایلهای تغییر یافته به همراه2 افزوده شده و 1 حذف شده
  1. 2 1
      drivers/memstick/core/mspro_block.c

+ 2 - 1
drivers/memstick/core/mspro_block.c

@@ -758,7 +758,7 @@ static int mspro_block_complete_req(struct memstick_dev *card, int error)
 
 
 		if (error || (card->current_mrq.tpc == MSPRO_CMD_STOP)) {
 		if (error || (card->current_mrq.tpc == MSPRO_CMD_STOP)) {
 			if (msb->data_dir == READ) {
 			if (msb->data_dir == READ) {
-				for (cnt = 0; cnt < msb->current_seg; cnt++)
+				for (cnt = 0; cnt < msb->current_seg; cnt++) {
 					t_len += msb->req_sg[cnt].length
 					t_len += msb->req_sg[cnt].length
 						 / msb->page_size;
 						 / msb->page_size;
 
 
@@ -766,6 +766,7 @@ static int mspro_block_complete_req(struct memstick_dev *card, int error)
 						t_len += msb->current_page - 1;
 						t_len += msb->current_page - 1;
 
 
 					t_len *= msb->page_size;
 					t_len *= msb->page_size;
+				}
 			}
 			}
 		} else
 		} else
 			t_len = blk_rq_bytes(msb->block_req);
 			t_len = blk_rq_bytes(msb->block_req);