Browse Source

pstore: Avoid race in module unloading

Technically, it might be possible for struct pstore_info to go out of
scope after the module_put(), so report the backend name first.

Signed-off-by: Kees Cook <keescook@chromium.org>
Kees Cook 8 years ago
parent
commit
1344dd86f3
1 changed files with 2 additions and 2 deletions
  1. 2 2
      fs/pstore/platform.c

+ 2 - 2
fs/pstore/platform.c

@@ -722,10 +722,10 @@ int pstore_register(struct pstore_info *psi)
 	 */
 	backend = psi->name;
 
-	module_put(owner);
-
 	pr_info("Registered %s as persistent store backend\n", psi->name);
 
+	module_put(owner);
+
 	return 0;
 }
 EXPORT_SYMBOL_GPL(pstore_register);