Переглянути джерело

usb: dwc3: gadget: make cleanup_completed_requests() return nothing

We don't need to return a value anymore here. Let's remove it.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Felipe Balbi 7 роки тому
батько
коміт
12a3a4ada8
1 змінених файлів з 4 додано та 9 видалено
  1. 4 9
      drivers/usb/dwc3/gadget.c

+ 4 - 9
drivers/usb/dwc3/gadget.c

@@ -2307,7 +2307,7 @@ static int dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep,
 	return 0;
 }
 
-static int dwc3_gadget_ep_cleanup_completed_requests(struct dwc3_ep *dep,
+static void dwc3_gadget_ep_cleanup_completed_requests(struct dwc3_ep *dep,
 		const struct dwc3_event_depevt *event, int status)
 {
 	struct dwc3_request	*req, *n;
@@ -2368,7 +2368,8 @@ static int dwc3_gadget_ep_cleanup_completed_requests(struct dwc3_ep *dep,
 				dev_WARN_ONCE(dep->dwc->dev,
 					      (req->request.actual == length),
 					      "There are some pending sg's that needs to be queued again\n");
-				return __dwc3_gadget_kick_transfer(dep);
+				__dwc3_gadget_kick_transfer(dep);
+				return;
 			}
 		}
 
@@ -2388,7 +2389,7 @@ static int dwc3_gadget_ep_cleanup_completed_requests(struct dwc3_ep *dep,
 	 * early.
 	 */
 	if (!dep->endpoint.desc)
-		return 1;
+		return;
 
 	if (usb_endpoint_xfer_isoc(dep->endpoint.desc) &&
 			list_empty(&dep->started_list)) {
@@ -2404,13 +2405,7 @@ static int dwc3_gadget_ep_cleanup_completed_requests(struct dwc3_ep *dep,
 			dwc3_stop_active_transfer(dep, true);
 			dep->flags = DWC3_EP_ENABLED;
 		}
-		return 1;
 	}
-
-	if (usb_endpoint_xfer_isoc(dep->endpoint.desc) && ioc)
-		return 0;
-
-	return 1;
 }
 
 static void dwc3_gadget_endpoint_frame_from_event(struct dwc3_ep *dep,