Эх сурвалжийг харах

jbd: Deletion of an unnecessary check before the function call "iput"

The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jan Kara <jack@suse.cz>
Markus Elfring 10 жил өмнө
parent
commit
11cc9f56a1
1 өөрчлөгдсөн 1 нэмэгдсэн , 2 устгасан
  1. 1 2
      fs/jbd/journal.c

+ 1 - 2
fs/jbd/journal.c

@@ -1373,8 +1373,7 @@ int journal_destroy(journal_t *journal)
 	}
 	mutex_unlock(&journal->j_checkpoint_mutex);
 
-	if (journal->j_inode)
-		iput(journal->j_inode);
+	iput(journal->j_inode);
 	if (journal->j_revoke)
 		journal_destroy_revoke(journal);
 	kfree(journal->j_wbuf);