Browse Source

usb: s3c2410_udc: correct reversed pullup logic

For some reason the code has always been disabling pullup
when asked to do the opposite. According to surrounding code
and gadget API this seems to be a mistake. This fix allows
UDC to be detected by host controller on recent kernels.

Signed-off-by: Sergiy Kibrik <sakib@meta.ua>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Sergiy Kibrik 10 years ago
parent
commit
10f095801c
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/usb/gadget/udc/s3c2410_udc.c

+ 1 - 1
drivers/usb/gadget/udc/s3c2410_udc.c

@@ -1487,7 +1487,7 @@ static int s3c2410_udc_pullup(struct usb_gadget *gadget, int is_on)
 
 
 	dprintk(DEBUG_NORMAL, "%s()\n", __func__);
 	dprintk(DEBUG_NORMAL, "%s()\n", __func__);
 
 
-	s3c2410_udc_set_pullup(udc, is_on ? 0 : 1);
+	s3c2410_udc_set_pullup(udc, is_on);
 	return 0;
 	return 0;
 }
 }