Prechádzať zdrojové kódy

drivers/misc/phantom.c: add missing warning messages in phantom_probe()

phantom_probe() can fail in many places.  Add missing warning messages in
pci_enable_device() and pci_request_regions().

Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Rahul Ruikar 15 rokov pred
rodič
commit
10ad5278bb
1 zmenil súbory, kde vykonal 6 pridanie a 2 odobranie
  1. 6 2
      drivers/misc/phantom.c

+ 6 - 2
drivers/misc/phantom.c

@@ -343,8 +343,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
 	int retval;
 	int retval;
 
 
 	retval = pci_enable_device(pdev);
 	retval = pci_enable_device(pdev);
-	if (retval)
+	if (retval) {
+		dev_err(&pdev->dev, "pci_enable_device failed!\n");
 		goto err;
 		goto err;
+	}
 
 
 	minor = phantom_get_free();
 	minor = phantom_get_free();
 	if (minor == PHANTOM_MAX_MINORS) {
 	if (minor == PHANTOM_MAX_MINORS) {
@@ -356,8 +358,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
 	phantom_devices[minor] = 1;
 	phantom_devices[minor] = 1;
 
 
 	retval = pci_request_regions(pdev, "phantom");
 	retval = pci_request_regions(pdev, "phantom");
-	if (retval)
+	if (retval) {
+		dev_err(&pdev->dev, "pci_request_regions failed!\n");
 		goto err_null;
 		goto err_null;
+	}
 
 
 	retval = -ENOMEM;
 	retval = -ENOMEM;
 	pht = kzalloc(sizeof(*pht), GFP_KERNEL);
 	pht = kzalloc(sizeof(*pht), GFP_KERNEL);