浏览代码

extcon: arizona: Ensure variables are set for headphone detection

The detecting flag really refers to the microphone detection stage and
as such should be cleared before arizona_identify_headphones is called.
Also the mic flag should be set before identify headphones is called as
well.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Charles Keepax 10 年之前
父节点
当前提交
0ffe8cbd51
共有 1 个文件被更改,包括 7 次插入4 次删除
  1. 7 4
      drivers/extcon/extcon-arizona.c

+ 7 - 4
drivers/extcon/extcon-arizona.c

@@ -765,10 +765,11 @@ static void arizona_micd_timeout_work(struct work_struct *work)
 	mutex_lock(&info->lock);
 	mutex_lock(&info->lock);
 
 
 	dev_dbg(info->arizona->dev, "MICD timed out, reporting HP\n");
 	dev_dbg(info->arizona->dev, "MICD timed out, reporting HP\n");
-	arizona_identify_headphone(info);
 
 
 	info->detecting = false;
 	info->detecting = false;
 
 
+	arizona_identify_headphone(info);
+
 	arizona_stop_mic(info);
 	arizona_stop_mic(info);
 
 
 	mutex_unlock(&info->lock);
 	mutex_unlock(&info->lock);
@@ -834,6 +835,9 @@ static void arizona_micd_detect(struct work_struct *work)
 
 
 	/* If we got a high impedence we should have a headset, report it. */
 	/* If we got a high impedence we should have a headset, report it. */
 	if (info->detecting && (val & ARIZONA_MICD_LVL_8)) {
 	if (info->detecting && (val & ARIZONA_MICD_LVL_8)) {
+		info->mic = true;
+		info->detecting = false;
+
 		arizona_identify_headphone(info);
 		arizona_identify_headphone(info);
 
 
 		ret = extcon_set_cable_state_(info->edev,
 		ret = extcon_set_cable_state_(info->edev,
@@ -849,8 +853,6 @@ static void arizona_micd_detect(struct work_struct *work)
 				ret);
 				ret);
 		}
 		}
 
 
-		info->mic = true;
-		info->detecting = false;
 		goto handled;
 		goto handled;
 	}
 	}
 
 
@@ -863,10 +865,11 @@ static void arizona_micd_detect(struct work_struct *work)
 	if (info->detecting && (val & MICD_LVL_1_TO_7)) {
 	if (info->detecting && (val & MICD_LVL_1_TO_7)) {
 		if (info->jack_flips >= info->micd_num_modes * 10) {
 		if (info->jack_flips >= info->micd_num_modes * 10) {
 			dev_dbg(arizona->dev, "Detected HP/line\n");
 			dev_dbg(arizona->dev, "Detected HP/line\n");
-			arizona_identify_headphone(info);
 
 
 			info->detecting = false;
 			info->detecting = false;
 
 
+			arizona_identify_headphone(info);
+
 			arizona_stop_mic(info);
 			arizona_stop_mic(info);
 		} else {
 		} else {
 			info->micd_mode++;
 			info->micd_mode++;