Browse Source

drm/amd/powerplay: fix pp_dpm_get_current_power_state() (v2)

This switch statement is missing breaks.

v2: agd: break in default case as well

Fixes: 2a5071056e6a ("drm/amd/powerplay: add global PowerPlay mutex.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Dan Carpenter 8 years ago
parent
commit
0f987cd0d7
1 changed files with 4 additions and 0 deletions
  1. 4 0
      drivers/gpu/drm/amd/powerplay/amd_powerplay.c

+ 4 - 0
drivers/gpu/drm/amd/powerplay/amd_powerplay.c

@@ -539,15 +539,19 @@ static enum amd_pm_state_type pp_dpm_get_current_power_state(void *handle)
 	switch (state->classification.ui_label) {
 	switch (state->classification.ui_label) {
 	case PP_StateUILabel_Battery:
 	case PP_StateUILabel_Battery:
 		pm_type = POWER_STATE_TYPE_BATTERY;
 		pm_type = POWER_STATE_TYPE_BATTERY;
+		break;
 	case PP_StateUILabel_Balanced:
 	case PP_StateUILabel_Balanced:
 		pm_type = POWER_STATE_TYPE_BALANCED;
 		pm_type = POWER_STATE_TYPE_BALANCED;
+		break;
 	case PP_StateUILabel_Performance:
 	case PP_StateUILabel_Performance:
 		pm_type = POWER_STATE_TYPE_PERFORMANCE;
 		pm_type = POWER_STATE_TYPE_PERFORMANCE;
+		break;
 	default:
 	default:
 		if (state->classification.flags & PP_StateClassificationFlag_Boot)
 		if (state->classification.flags & PP_StateClassificationFlag_Boot)
 			pm_type = POWER_STATE_TYPE_INTERNAL_BOOT;
 			pm_type = POWER_STATE_TYPE_INTERNAL_BOOT;
 		else
 		else
 			pm_type = POWER_STATE_TYPE_DEFAULT;
 			pm_type = POWER_STATE_TYPE_DEFAULT;
+		break;
 	}
 	}
 	mutex_unlock(&pp_handle->pp_lock);
 	mutex_unlock(&pp_handle->pp_lock);