Browse Source

regulator: fix simple_return.cocci warnings

Simplify a trivial if-return sequence and combine with a
preceding function call.

Generated by: scripts/coccinelle/misc/simple_return.cocci

CC: Mark Brown <broonie@kernel.org>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
Julia Lawall 10 years ago
parent
commit
0f94bffad4
1 changed files with 1 additions and 5 deletions
  1. 1 5
      drivers/regulator/qcom_spmi-regulator.c

+ 1 - 5
drivers/regulator/qcom_spmi-regulator.c

@@ -710,12 +710,8 @@ static int spmi_regulator_ult_lo_smps_set_voltage(struct regulator_dev *rdev,
 	if (range_sel == 1)
 		voltage_sel |= ULT_SMPS_RANGE_SPLIT;
 
-	ret = spmi_vreg_update_bits(vreg, SPMI_COMMON_REG_VOLTAGE_SET,
+	return spmi_vreg_update_bits(vreg, SPMI_COMMON_REG_VOLTAGE_SET,
 	       voltage_sel, 0xff);
-	if (ret)
-		return ret;
-
-	return 0;
 }
 
 static int spmi_regulator_ult_lo_smps_get_voltage(struct regulator_dev *rdev)