Explorar o código

ALSA: usb-audio: Fix NULL dereference in create_fixed_stream_quirk()

create_fixed_stream_quirk() may cause a NULL-pointer dereference by
accessing the non-existing endpoint when a USB device with a malformed
USB descriptor is used.

This patch avoids it simply by adding a sanity check of bNumEndpoints
before the accesses.

Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=971125
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai %!s(int64=9) %!d(string=hai) anos
pai
achega
0f886ca127
Modificáronse 1 ficheiros con 6 adicións e 0 borrados
  1. 6 0
      sound/usb/quirks.c

+ 6 - 0
sound/usb/quirks.c

@@ -180,6 +180,12 @@ static int create_fixed_stream_quirk(struct snd_usb_audio *chip,
 	}
 	}
 	alts = &iface->altsetting[fp->altset_idx];
 	alts = &iface->altsetting[fp->altset_idx];
 	altsd = get_iface_desc(alts);
 	altsd = get_iface_desc(alts);
+	if (altsd->bNumEndpoints < 1) {
+		kfree(fp);
+		kfree(rate_table);
+		return -EINVAL;
+	}
+
 	fp->protocol = altsd->bInterfaceProtocol;
 	fp->protocol = altsd->bInterfaceProtocol;
 
 
 	if (fp->datainterval == 0)
 	if (fp->datainterval == 0)