Browse Source

platform/x86: dell-smbios: Fix memory leaks in build_tokens_sysfs()

We're freeing "value_name" which is NULL, so that's a no-op, but we
intended to free "location_name" instead.  And then we don't free the
names in token_location_attrs[0] and token_value_attrs[0].

Fixes: 33b9ca1e53b4 ("platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Dan Carpenter 7 years ago
parent
commit
0e5b09b165
1 changed files with 2 additions and 2 deletions
  1. 2 2
      drivers/platform/x86/dell-smbios-base.c

+ 2 - 2
drivers/platform/x86/dell-smbios-base.c

@@ -514,7 +514,7 @@ static int build_tokens_sysfs(struct platform_device *dev)
 		continue;
 		continue;
 
 
 loop_fail_create_value:
 loop_fail_create_value:
-		kfree(value_name);
+		kfree(location_name);
 		goto out_unwind_strings;
 		goto out_unwind_strings;
 	}
 	}
 	smbios_attribute_group.attrs = token_attrs;
 	smbios_attribute_group.attrs = token_attrs;
@@ -525,7 +525,7 @@ loop_fail_create_value:
 	return 0;
 	return 0;
 
 
 out_unwind_strings:
 out_unwind_strings:
-	for (i = i-1; i > 0; i--) {
+	while (i--) {
 		kfree(token_location_attrs[i].attr.name);
 		kfree(token_location_attrs[i].attr.name);
 		kfree(token_value_attrs[i].attr.name);
 		kfree(token_value_attrs[i].attr.name);
 	}
 	}