瀏覽代碼

SUNRPC: Use unsigned loop and array index in svc_init_buffer()

Clean up: Suppress a harmless compiler warning.

Index rq_pages[] with an unsigned type.  Make "pages" unsigned as well,
as it never represents a value less than zero.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Chuck Lever 17 年之前
父節點
當前提交
0dc220f081
共有 1 個文件被更改,包括 2 次插入3 次删除
  1. 2 3
      net/sunrpc/svc.c

+ 2 - 3
net/sunrpc/svc.c

@@ -510,8 +510,7 @@ EXPORT_SYMBOL(svc_destroy);
 static int
 static int
 svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
 svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
 {
 {
-	int pages;
-	int arghi;
+	unsigned int pages, arghi;
 
 
 	pages = size / PAGE_SIZE + 1; /* extra page as we hold both request and reply.
 	pages = size / PAGE_SIZE + 1; /* extra page as we hold both request and reply.
 				       * We assume one is at most one page
 				       * We assume one is at most one page
@@ -525,7 +524,7 @@ svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
 		rqstp->rq_pages[arghi++] = p;
 		rqstp->rq_pages[arghi++] = p;
 		pages--;
 		pages--;
 	}
 	}
-	return ! pages;
+	return pages == 0;
 }
 }
 
 
 /*
 /*