Browse Source

staging: most: remove redundant call to wake_up_interruptible

This patch prevents the cdev module from rousing the channel wait queue in
case the channel is about to be closed. It is safe to do so, because the
application can not be waiting within read or write and at the same time
be calling close.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm 9 years ago
parent
commit
0ccaa6de8e
1 changed files with 0 additions and 2 deletions
  1. 0 2
      drivers/staging/most/aim-cdev/cdev.c

+ 0 - 2
drivers/staging/most/aim-cdev/cdev.c

@@ -127,7 +127,6 @@ static int aim_close(struct inode *inode, struct file *filp)
 		kfifo_free(&channel->fifo);
 		list_del(&channel->list);
 		ida_simple_remove(&minor_id, MINOR(channel->devno));
-		wake_up_interruptible(&channel->wq);
 		kfree(channel);
 		return 0;
 	}
@@ -139,7 +138,6 @@ static int aim_close(struct inode *inode, struct file *filp)
 		most_put_mbo(channel->stacked_mbo);
 	ret = most_stop_channel(channel->iface, channel->channel_id, &cdev_aim);
 	atomic_dec(&channel->access_ref);
-	wake_up_interruptible(&channel->wq);
 	return ret;
 }