瀏覽代碼

dm space map metadata: skip useless memcpy in metadata_ll_init_index()

When metadata_ll_init_index() is called by sm_ll_new_metadata(),
ll->mi_le hasn't been initialized yet. So, when
metadata_ll_init_index() copies the contents of ll->mi_le into the
newly allocated bitmap_root, it is just copying garbage. ll->mi_le
will be allocated later in sm_ll_extend() and copied into the
bitmap_root, in sm_ll_commit().

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Benjamin Marzinski 9 年之前
父節點
當前提交
0c79ce0b75
共有 1 個文件被更改,包括 0 次插入1 次删除
  1. 0 1
      drivers/md/persistent-data/dm-space-map-common.c

+ 0 - 1
drivers/md/persistent-data/dm-space-map-common.c

@@ -547,7 +547,6 @@ static int metadata_ll_init_index(struct ll_disk *ll)
 	if (r < 0)
 	if (r < 0)
 		return r;
 		return r;
 
 
-	memcpy(dm_block_data(b), &ll->mi_le, sizeof(ll->mi_le));
 	ll->bitmap_root = dm_block_location(b);
 	ll->bitmap_root = dm_block_location(b);
 
 
 	dm_tm_unlock(ll->tm, b);
 	dm_tm_unlock(ll->tm, b);