浏览代码

mtd: fsmc_nand: fix handling of wait_for_completion_timeout return value

wait_for_completion_timeout does not return negative values so
result handling here does not need to check for negative return.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Nicholas Mc Guire 10 年之前
父节点
当前提交
0bda3e1944
共有 1 个文件被更改,包括 2 次插入3 次删除
  1. 2 3
      drivers/mtd/nand/fsmc_nand.c

+ 2 - 3
drivers/mtd/nand/fsmc_nand.c

@@ -604,11 +604,10 @@ static int dma_xfer(struct fsmc_nand_data *host, void *buffer, int len,
 	ret =
 	wait_for_completion_timeout(&host->dma_access_complete,
 				msecs_to_jiffies(3000));
-	if (ret <= 0) {
+	if (ret == 0) {
 		dmaengine_terminate_all(chan);
 		dev_err(host->dev, "wait_for_completion_timeout\n");
-		if (!ret)
-			ret = -ETIMEDOUT;
+		ret = -ETIMEDOUT;
 		goto unmap_dma;
 	}