浏览代码

drm/ttm: Don't move non-existing data

If ttm_bo_move_memcpy was instructed to move a non-populated ttm to
io memory, it would first populate the ttm, then move the data and then
destroy the ttm. That's stupid. However, some drivers might have relied on
this to clear io memory from old stuff. So instead of a NOP, which would
be the most efficient, just clear the destination.

Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Jakob Bornecrantz <jakob@vmware.com>
Thomas Hellstrom 12 年之前
父节点
当前提交
0bc254257b
共有 1 个文件被更改,包括 5 次插入2 次删除
  1. 5 2
      drivers/gpu/drm/ttm/ttm_bo_util.c

+ 5 - 2
drivers/gpu/drm/ttm/ttm_bo_util.c

@@ -350,10 +350,13 @@ int ttm_bo_move_memcpy(struct ttm_buffer_object *bo,
 		goto out2;
 		goto out2;
 
 
 	/*
 	/*
-	 * Move nonexistent data. NOP.
+	 * Don't move nonexistent data. Clear destination instead.
 	 */
 	 */
-	if (old_iomap == NULL && ttm == NULL)
+	if (old_iomap == NULL &&
+	    (ttm == NULL || ttm->state == tt_unpopulated)) {
+		memset_io(new_iomap, 0, new_mem->num_pages*PAGE_SIZE);
 		goto out2;
 		goto out2;
+	}
 
 
 	/*
 	/*
 	 * TTM might be null for moves within the same region.
 	 * TTM might be null for moves within the same region.