浏览代码

ATM-nicstar: Refactor a dev_alloc_skb() call in dequeue_rx()

The script "checkpatch.pl" can point out that assignments should usually
not be performed within condition checks.
Thus move an assignment for a local variable to a separate statement
in this function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Markus Elfring 9 年之前
父节点
当前提交
0ba8abb770
共有 1 个文件被更改,包括 2 次插入1 次删除
  1. 2 1
      drivers/atm/nicstar.c

+ 2 - 1
drivers/atm/nicstar.c

@@ -2023,7 +2023,8 @@ static void dequeue_rx(ns_dev * card, ns_rsqe * rsqe)
 
 
 		cell = skb->data;
 		cell = skb->data;
 		for (i = ns_rsqe_cellcount(rsqe); i; i--) {
 		for (i = ns_rsqe_cellcount(rsqe); i; i--) {
-			if ((sb = dev_alloc_skb(NS_SMSKBSIZE)) == NULL) {
+			sb = dev_alloc_skb(NS_SMSKBSIZE);
+			if (!sb) {
 				printk
 				printk
 				    ("nicstar%d: Can't allocate buffers for aal0.\n",
 				    ("nicstar%d: Can't allocate buffers for aal0.\n",
 				     card->index);
 				     card->index);