Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

ib_srpt: Destroy cm_id before destroying QP.

This patch fixes a bug where ib_destroy_cm_id() was incorrectly being called
after srpt_destroy_ch_ib() had destroyed the active QP.

This would result in the following failed SRP_LOGIN_REQ messages:

Received SRP_LOGIN_REQ with i_port_id 0x0:0x2590ffff1762bd, t_port_id 0x2c903009f8f40:0x2c903009f8f40 and it_iu_len 260 on port 1 (guid=0xfe80000000000000:0x2c903009f8f41)
Received SRP_LOGIN_REQ with i_port_id 0x0:0x2590ffff1758f9, t_port_id 0x2c903009f8f40:0x2c903009f8f40 and it_iu_len 260 on port 2 (guid=0xfe80000000000000:0x2c903009f8f42)
Received SRP_LOGIN_REQ with i_port_id 0x0:0x2590ffff175941, t_port_id 0x2c903009f8f40:0x2c903009f8f40 and it_iu_len 260 on port 2 (guid=0xfe80000000000000:0x2c90300a3cfb2)
Received SRP_LOGIN_REQ with i_port_id 0x0:0x2590ffff176299, t_port_id 0x2c903009f8f40:0x2c903009f8f40 and it_iu_len 260 on port 1 (guid=0xfe80000000000000:0x2c90300a3cfb1)
mlx4_core 0000:84:00.0: command 0x19 failed: fw status = 0x9
rejected SRP_LOGIN_REQ because creating a new RDMA channel failed.
Received SRP_LOGIN_REQ with i_port_id 0x0:0x2590ffff176299, t_port_id 0x2c903009f8f40:0x2c903009f8f40 and it_iu_len 260 on port 1 (guid=0xfe80000000000000:0x2c90300a3cfb1)
mlx4_core 0000:84:00.0: command 0x19 failed: fw status = 0x9
rejected SRP_LOGIN_REQ because creating a new RDMA channel failed.
Received SRP_LOGIN_REQ with i_port_id 0x0:0x2590ffff176299, t_port_id 0x2c903009f8f40:0x2c903009f8f40 and it_iu_len 260 on port 1 (guid=0xfe80000000000000:0x2c90300a3cfb1)

Reported-by: Navin Ahuja <navin.ahuja@saratoga-speed.com>
Cc: stable@vger.kernel.org # 3.3+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Nicholas Bellinger 12 years ago
parent
3e9e01de5e
commit
0b41d6ca61
1 changed files with 2 additions and 2 deletions
Unified View Show Diff Stats
  1. 2 2
      drivers/infiniband/ulp/srpt/ib_srpt.c

+ 2 - 2
drivers/infiniband/ulp/srpt/ib_srpt.c
View File 

@@ -2358,6 +2358,8 @@ static void srpt_release_channel_work(struct work_struct *w)
 
 	transport_deregister_session(se_sess);
 
 	transport_deregister_session(se_sess);
 
 	ch->sess = NULL;
 
 	ch->sess = NULL;
 
 
 
+	ib_destroy_cm_id(ch->cm_id);
 
+
 
 	srpt_destroy_ch_ib(ch);
 
 	srpt_destroy_ch_ib(ch);
 
 
 
 	srpt_free_ioctx_ring((struct srpt_ioctx **)ch->ioctx_ring,
 
 	srpt_free_ioctx_ring((struct srpt_ioctx **)ch->ioctx_ring,
 
@@ -2368,8 +2370,6 @@ static void srpt_release_channel_work(struct work_struct *w)
 
 	list_del(&ch->list);
 
 	list_del(&ch->list);
 
 	spin_unlock_irq(&sdev->spinlock);
 
 	spin_unlock_irq(&sdev->spinlock);
 
 
 
-	ib_destroy_cm_id(ch->cm_id);
 
-
 
 	if (ch->release_done)
 
 	if (ch->release_done)
 
 		complete(ch->release_done);
 
 		complete(ch->release_done);