Browse Source

gpio: of: add missing of_node_put() in of_gpiochip_scan_gpios()

When terminating for_each_available_child_of_node() iteration
with break or return, of_node_put() should be used to prevent
stale device node references from being left behind.

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Wei Yongjun 8 năm trước cách đây
mục cha
commit
09e258af4e
1 tập tin đã thay đổi với 3 bổ sung1 xóa
  1. 3 1
      drivers/gpio/gpiolib-of.c

+ 3 - 1
drivers/gpio/gpiolib-of.c

@@ -247,8 +247,10 @@ static int of_gpiochip_scan_gpios(struct gpio_chip *chip)
 			continue;
 
 		ret = gpiod_hog(desc, name, lflags, dflags);
-		if (ret < 0)
+		if (ret < 0) {
+			of_node_put(np);
 			return ret;
+		}
 	}
 
 	return 0;