Эх сурвалжийг харах

gpiolib: acpi: Don't contaminate return parameter in case of error

If error occurs, leave lookup parameter untouched.

There is no functional change, since all current callers just bail out
in case of error without using the assigned pieces.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Andy Shevchenko 7 жил өмнө
parent
commit
08be1a795d

+ 1 - 1
drivers/gpio/gpiolib-acpi.c

@@ -585,7 +585,6 @@ static int acpi_gpio_property_lookup(struct fwnode_handle *fwnode,
 	 * The property was found and resolved, so need to lookup the GPIO based
 	 * The property was found and resolved, so need to lookup the GPIO based
 	 * on returned args.
 	 * on returned args.
 	 */
 	 */
-	lookup->adev = args.adev;
 	if (args.nargs != 3)
 	if (args.nargs != 3)
 		return -EPROTO;
 		return -EPROTO;
 
 
@@ -593,6 +592,7 @@ static int acpi_gpio_property_lookup(struct fwnode_handle *fwnode,
 	lookup->pin_index = args.args[1];
 	lookup->pin_index = args.args[1];
 	lookup->active_low = !!args.args[2];
 	lookup->active_low = !!args.args[2];
 
 
+	lookup->adev = args.adev;
 	return 0;
 	return 0;
 }
 }