Просмотр исходного кода

intel_idle: Propagate hot plug errors.

If a cpuidle registration error occurs during the hot plug notifier
callback, we should really inform the hot plug machinery instead of
just ignoring the error.  This patch changes the callback to properly
return on error.

Signed-off-by: Richard Cochran <rcochran@linutronix.de>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Richard Cochran 9 лет назад
Родитель
Сommit
08820546e4
1 измененных файлов с 5 добавлено и 2 удалено
  1. 5 2
      drivers/idle/intel_idle.c

+ 5 - 2
drivers/idle/intel_idle.c

@@ -818,8 +818,11 @@ static int cpu_hotplug_notify(struct notifier_block *n,
 		 * driver in this case
 		 * driver in this case
 		 */
 		 */
 		dev = per_cpu_ptr(intel_idle_cpuidle_devices, hotcpu);
 		dev = per_cpu_ptr(intel_idle_cpuidle_devices, hotcpu);
-		if (!dev->registered)
-			intel_idle_cpu_init(hotcpu);
+		if (dev->registered)
+			break;
+
+		if (intel_idle_cpu_init(hotcpu))
+			return NOTIFY_BAD;
 
 
 		break;
 		break;
 	}
 	}