浏览代码

irqchip/mbigen: Checking for IS_ERR() instead of NULL

of_platform_device_create() returns NULL on error, it never returns
error pointers.

Fixes: ed2a1002d25c ('irqchip/mbigen: Handle multiple device nodes in a mbigen module')
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Dan Carpenter 9 年之前
父节点
当前提交
086eec2de0
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/irqchip/irq-mbigen.c

+ 2 - 2
drivers/irqchip/irq-mbigen.c

@@ -263,8 +263,8 @@ static int mbigen_device_probe(struct platform_device *pdev)
 
 
 		parent = platform_bus_type.dev_root;
 		parent = platform_bus_type.dev_root;
 		child = of_platform_device_create(np, NULL, parent);
 		child = of_platform_device_create(np, NULL, parent);
-		if (IS_ERR(child))
-			return PTR_ERR(child);
+		if (!child)
+			return -ENOMEM;
 
 
 		if (of_property_read_u32(child->dev.of_node, "num-pins",
 		if (of_property_read_u32(child->dev.of_node, "num-pins",
 					 &num_pins) < 0) {
 					 &num_pins) < 0) {