浏览代码

ethtool: Use kcalloc instead of kmalloc for ethtool_get_strings

It seems that kernel memory can leak into userspace by a
kmalloc, ethtool_get_strings, then copy_to_user sequence.

Avoid this by using kcalloc to zero fill the copied buffer.

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Joe Perches 9 年之前
父节点
当前提交
077cb37fcf
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      net/core/ethtool.c

+ 1 - 1
net/core/ethtool.c

@@ -1284,7 +1284,7 @@ static int ethtool_get_strings(struct net_device *dev, void __user *useraddr)
 
 
 	gstrings.len = ret;
 	gstrings.len = ret;
 
 
-	data = kmalloc(gstrings.len * ETH_GSTRING_LEN, GFP_USER);
+	data = kcalloc(gstrings.len, ETH_GSTRING_LEN, GFP_USER);
 	if (!data)
 	if (!data)
 		return -ENOMEM;
 		return -ENOMEM;