浏览代码

uml: flush stdout before forking

I was seeing some really weird behaviour where piping UML's output
somewhere would cause output to get duplicated:

  $ ./vmlinux | head -n 40
  Checking that ptrace can change system call numbers...Core dump limits :
          soft - 0
          hard - NONE
  OK
  Checking syscall emulation patch for ptrace...Core dump limits :
          soft - 0
          hard - NONE
  OK
  Checking advanced syscall emulation patch for ptrace...Core dump limits :
          soft - 0
          hard - NONE
  OK
  Core dump limits :
          soft - 0
          hard - NONE

This is because these tests do a fork() which duplicates the non-empty
stdout buffer, then glibc flushes the duplicated buffer as each child
exits.

A simple workaround is to flush before forking.

Cc: stable@vger.kernel.org
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Vegard Nossum 9 年之前
父节点
当前提交
0754fb298f
共有 1 个文件被更改,包括 2 次插入0 次删除
  1. 2 0
      arch/um/os-Linux/start_up.c

+ 2 - 0
arch/um/os-Linux/start_up.c

@@ -94,6 +94,8 @@ static int start_ptraced_child(void)
 {
 {
 	int pid, n, status;
 	int pid, n, status;
 
 
+	fflush(stdout);
+
 	pid = fork();
 	pid = fork();
 	if (pid == 0)
 	if (pid == 0)
 		ptrace_child();
 		ptrace_child();