Browse Source

net/mlx5: Fix not releasing read lock when adding flow rules

If building match list fg fails and we never jumped to
search_again_locked label then the function returned without
unlocking the read lock.

Fixes: bd71b08ec2ee ("net/mlx5: Support multiple updates of steering rules in parallel")
Signed-off-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Roi Dayan 7 years ago
parent
commit
071304772f
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/net/ethernet/mellanox/mlx5/core/fs_core.c

+ 2 - 0
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c

@@ -1726,6 +1726,8 @@ search_again_locked:
 	if (err) {
 		if (take_write)
 			up_write_ref_node(&ft->node);
+		else
+			up_read_ref_node(&ft->node);
 		return ERR_PTR(err);
 	}