Browse Source

drm/rockchip: dw_hdmi: Don't call platform_set_drvdata()

The Rockchip dw_hdmi driver just called platform_set_drvdata() to get
your hopes up that maybe, somehow, you'd be able to retrieve the 'struct
rockchip_hdmi' from a pointer to the 'struct device'.  You can't.  When
we call dw_hdmi_bind() the main driver calls dev_set_drvdata(), which
clobbers our setting.

Let's just remove the platform_set_drvdata() to avoid dashing people's
hopes.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Douglas Anderson 9 years ago
parent
commit
06b898ec84
1 changed files with 0 additions and 2 deletions
  1. 0 2
      drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

+ 0 - 2
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

@@ -271,8 +271,6 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master,
 	if (!iores)
 	if (!iores)
 		return -ENXIO;
 		return -ENXIO;
 
 
-	platform_set_drvdata(pdev, hdmi);
-
 	encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node);
 	encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node);
 	/*
 	/*
 	 * If we failed to find the CRTC(s) which this encoder is
 	 * If we failed to find the CRTC(s) which this encoder is